Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: roachtest: no longer show other errors if a test times out #115467

Merged
merged 1 commit into from
Dec 4, 2023
Merged

release-23.2: roachtest: no longer show other errors if a test times out #115467

merged 1 commit into from
Dec 4, 2023
+26 −3

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 1, 2023 •
edited by DarrylWong
Loading

Backport 1/1 commits from #115286 on behalf of @DarrylWong.

/cc @cockroachdb/release

When a test times out, it often leads to other failures (i.e. context cancelled). However, these are often just noise and distract from the root cause of the failures, the timeout.

This change makes it so when a timeout failure is added, it suppresses future errors from being shown in github posts and the test failure message. They are still logged in their respective failure.log files.

Epic: none
Release note: none
Fixes: #114565

Release justification: test infra only change

@DarrylWong
roachtest: no longer show other errors if a test times out
1fe7c9d 
When a test times out, it often leads to other failures
(i.e. context cancelled). However, these are often just
noise and distract from the root cause of the failures,
the timeout.

This change makes it so when a timeout failure is added,
it suppresses future errors from being shown in github posts
and the test failure message. They are still logged in their
respective failure.log files.

Epic: none
Release note: none
Fixes: #114565
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 1, 2023 22:17
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115286 branch from fca6642 to 9374786 Compare December 1, 2023 22:17
@blathers-crl blathers-crl bot requested review from herkolategan and srosenberg and removed request for a team December 1, 2023 22:17
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115286 branch from be048c1 to 1fe7c9d Compare December 1, 2023 22:17
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 1, 2023
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Dec 1, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from renatolabs December 1, 2023 22:17
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 1, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@DarrylWong DarrylWong merged commit 228ad8e into release-23.2 Dec 4, 2023
5 of 6 checks passed
@DarrylWong DarrylWong deleted the blathers/backport-release-23.2-115286 branch December 4, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srosenberg srosenberg srosenberg approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs

Assignees

@DarrylWong DarrylWong

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @srosenberg @DarrylWong